Skip to content

fix(@angular/cli): postCssOption - #8667

Closed
jycouet wants to merge 1 commit into
angular:masterfrom
jycouet:setPostCSS
Closed

fix(@angular/cli): postCssOption#8667
jycouet wants to merge 1 commit into
angular:masterfrom
jycouet:setPostCSS

Conversation

@jycouet

@jycouet jycouet commented Nov 28, 2017

Copy link
Copy Markdown

Fix: #7991

Like this, we can turn off the flag withPostCssWarnings in .angular-cli.json:

"defaults": {
  "build": {
    "withPostCssWarnings": false
  }
}

The default value is set to true so that we have the same behaviour as the current v1.5.x

import { getGlobalVariable } from '../../utils/env';
import { updateJsonFile } from '../../utils/project';

const webpackGoodRegEx = /webpack: Compiled successfully./;

@YoannBureau YoannBureau Dec 1, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to webpackSuccessRegEx

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this, but it won't fix failing tests right?

@clydin

clydin commented Jan 10, 2018

Copy link
Copy Markdown
Member

Superseded by #8874

@clydin clydin closed this Jan 10, 2018
@jycouet
jycouet deleted the setPostCSS branch January 11, 2018 22:01
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postcss-custom-properties warnings when overriding css variables

4 participants